Add support for ADI MAX32690 microcontroller #9667

Brandon-Hurst · 2024-09-27T15:36:06Z

Description

Add support for 2 boards: MAX32690EVKIT and AD-APARD32690-SL.

Status

At the moment, this port only includes digitalio in addition to the supervisor and USB workflow required to get CircuitPython functioning. Pinouts listed are currently just the MCU pins; happy to change as needed to better match any requirements for form factor or pin function. I plan to follow this up with a busio PR soon, but will be more tied up in the next couple months. Still happy to make changes as needed to this PR though.

USB Endpoint Enumeration Change

There is a small important bit I had to change to the way CircuitPython handles settings up USB Endpoints:

TUSB has some devices (such as MAX32) which are not capable of having full-duplex endpoints. This is true for a few devices besides MAX32, but also for MAX32 (in particular a lot of others share the same IP).
There is a #define for TUD_ENDPOINT_ONE_DIRECTION_ONLY accounted for by TinyUSB, but not by the way CircuitPython initializes an endpoint on these devices. The change itself is very minimal -- it just increments the endpoint after setting up either an IN our OUT instead of both to an endpoint pair. I made it for all device classes and it should cover all cases for other devices as well.

Many thanks to @tannewt and @dhalbert for the help :)

…ent/unstub, but builds clean.

…into port/max32690

- Added simple status LED for initial testing - Generally cleaned up & implemented supervisor/port.c - Added some additional commenting from supervisor headers - Fixed a linkerscript issue copying .text into FLASH_ISR

- (build): added hex & bin targets for executable. - (build): temporarily modified .ld due to issue exiting MAX32 ROM code - (flash): added flash target for jlink & msdk, along with helper files under tools/ - Reorganized mpconfigport.mk for clarity - Moved flash driver & LED/PB definitions to board files (mpconfigboard._)

…Placed in supervisor/port.c - Moved LEDs & PBs from supervisor/port.c to boards/$(BOARD)/board.c for APARD - Reviewed Processor.c in common-hal/microcontroller - Prepared stubs for common-hal/microcontroller/Pin.c

…. - Enabled USB-based modules & dependencies in mpconfigport.mk

…pected.

…umerates but has some issues starting interfaces for CDC/MSC/HID.

…be usable. - Had to adjust some shared modules to account for MAX32 devices not supporting IN/OUT endpoints on the same EP #

… Fixed bugs with Internal Flash filesystem. Files now write & read back correctly. - Added copyright headers for all files.

…h in microcontroller/Pin.c

…into port/max32690

…re. Added priority to remaining TODOs (low)

tannewt

Thanks for the new port! I'm excited to try it. I've added a few comments. Nothing major.

ports/analog/Makefile

ports/analog/boards/apard32690/README.md

ports/analog/boards/apard32690/board.c

ports/analog/boards/apard32690/pins.c

ports/analog/boards/max32690evkit/board.c

tannewt · 2024-09-27T16:55:21Z

ports/analog/common-hal/digitalio/DigitalInOut.c

+    // todo (low): MSDK Hardware does not support open-drain configuration except
+    // todo (low): when directly managed by a peripheral such as I2C.
+    // todo (low): find a way to signal this to any upstream code


The code in this file can implement open drain itself by switching the output buffer off and on. Here is the SAMD code:

circuitpython/ports/atmel-samd/common-hal/digitalio/DigitalInOut.c

Lines 77 to 96 in ec5cca6

void common_hal_digitalio_digitalinout_set_value(

digitalio_digitalinout_obj_t *self, bool value) {

const uint8_t pin = self->pin->number;

const uint8_t port = GPIO_PORT(pin);

const uint32_t pin_mask = 1U << GPIO_PIN(pin);

if (value) {

if (self->open_drain) {

// Assertion: pull is off, so the pin is floating in this case.

// We do open-drain high output (no sinking of current)

// by changing the direction to input with no pulls.

hri_port_clear_DIR_DIR_bf(PORT, port, pin_mask);

} else {

hri_port_set_DIR_DIR_bf(PORT, port, pin_mask);

hri_port_set_OUT_OUT_bf(PORT, port, pin_mask);

}

} else {

hri_port_set_DIR_DIR_bf(PORT, port, pin_mask);

hri_port_clear_OUT_OUT_bf(PORT, port, pin_mask);

}

}

ports/analog/mpconfigport.h

ports/analog/supervisor/port.c

…h interrupt_after_ticks. - Move LED inidcator to STATUS_LED code.

… GPIO Port 4 (different on MAX32690). - Added MCR defs to max32_port.h.

…or Sphinx docs.

U-ANALOG\BHurst and others added 20 commits August 14, 2024 14:29

Initial commit for ADI MAX32690 support. Still many modules to implem…

5ccf473

…ent/unstub, but builds clean.

Merge branch 'main' of https://github.com/Brandon-Hurst/circuitpython …

fd8bd72

…into port/max32690

- Added 1/1024 s tick based on 4096 Hz RTC.

6d816ef

- Added simple status LED for initial testing - Generally cleaned up & implemented supervisor/port.c - Added some additional commenting from supervisor headers - Fixed a linkerscript issue copying .text into FLASH_ISR

-Added USB via tinyUSB. Still need to test/debug before REPL is ready…

79ed8ab

…. - Enabled USB-based modules & dependencies in mpconfigport.mk

Fixed USB endpoint speed issue w/ configuration setting

94d0c99

Fixed some RTC alarm setup issues; tick interrupts now function as ex…

3b4638e

…pected.

Reorganized some build files & commented out WFI to debug USB. USB en…

1c0205d

…umerates but has some issues starting interfaces for CDC/MSC/HID.

- Fixed USB endpoint descriptor problems. All USB classes should now …

4848bf6

…be usable. - Had to adjust some shared modules to account for MAX32 devices not supporting IN/OUT endpoints on the same EP #

- Fixed USB issues. REPL & CIRCUITPY: drive now function correctly! -…

003b7c5

… Fixed bugs with Internal Flash filesystem. Files now write & read back correctly. - Added copyright headers for all files.

Added digitalio module.

839ae40

Added max32690 EVKIT board & changed APARD board to apard32690

1f9b4b4

Reordered mpconfigport.mk; replaced MXC_SYS includes with max32_port.…

adef40c

…h in microcontroller/Pin.c

Merge branch 'main' of https://github.com/Brandon-Hurst/circuitpython …

99ed812

…into port/max32690

Moved GPIO ports to board.c to make it easy to add boards in the futu…

74b5870

…re. Added priority to remaining TODOs (low)

Updated USB PID for max32690evkit

10ddfe0

Formatting fixes missed by local pre-commit runner

8530521

Add "analog" to shared_bindings_matrix.py

bdc77c5

More pre-commit fixes.

3a73b18

tannewt self-requested a review September 27, 2024 16:38

U-ANALOG\BHurst and others added 2 commits September 27, 2024 09:46

Manual pre-commit fix for all requisite files.

5541ae3

Manual pre-commit fix for last delinquent file

cce1fbb

tannewt requested changes Sep 27, 2024

View reviewed changes

Brandon-Hurst and others added 6 commits October 1, 2024 08:44

- Move SysTick init from board_init to port_init. - Fix RTC issue wit…

2bf1ed7

…h interrupt_after_ticks. - Move LED inidcator to STATUS_LED code.

- Changed board.c to match silkscreen. - Added digitalio handling for…

4f87c17

… GPIO Port 4 (different on MAX32690). - Added MCR defs to max32_port.h.

pre-commit formatting fixes

1c0122b

more pre-commit fixes

8114191

final pre-commit fix

e9f9d91

Fix CI run issues with docs & tlsf submodule

02baf37

- Add elf target for CI build. - Add ports/analog/README to toctree f…

7570a75

…or Sphinx docs.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ADI MAX32690 microcontroller #9667

Add support for ADI MAX32690 microcontroller #9667

Brandon-Hurst commented Sep 27, 2024 •

edited

Loading

tannewt left a comment

tannewt Sep 27, 2024

	void common_hal_digitalio_digitalinout_set_value(
	digitalio_digitalinout_obj_t *self, bool value) {
	const uint8_t pin = self->pin->number;
	const uint8_t port = GPIO_PORT(pin);
	const uint32_t pin_mask = 1U << GPIO_PIN(pin);
	if (value) {
	if (self->open_drain) {
	// Assertion: pull is off, so the pin is floating in this case.
	// We do open-drain high output (no sinking of current)
	// by changing the direction to input with no pulls.
	hri_port_clear_DIR_DIR_bf(PORT, port, pin_mask);
	} else {
	hri_port_set_DIR_DIR_bf(PORT, port, pin_mask);
	hri_port_set_OUT_OUT_bf(PORT, port, pin_mask);
	}
	} else {
	hri_port_set_DIR_DIR_bf(PORT, port, pin_mask);
	hri_port_clear_OUT_OUT_bf(PORT, port, pin_mask);
	}
	}

Add support for ADI MAX32690 microcontroller #9667

Are you sure you want to change the base?

Add support for ADI MAX32690 microcontroller #9667

Conversation

Brandon-Hurst commented Sep 27, 2024 • edited Loading

Description

Status

USB Endpoint Enumeration Change

tannewt left a comment

Choose a reason for hiding this comment

tannewt Sep 27, 2024

Choose a reason for hiding this comment

Brandon-Hurst commented Sep 27, 2024 •

edited

Loading